Q.buddleia bush leaves turning yellow but still flowering
I wondered if I need Ericaceous compost. I have two other buddleias with no problems though.

Yellowing leaves generally indicates a watering issue, to much or to little.
Insects also can become an issue that may cause yellowing of leaves when the plant is stressed.
Adjust water as needed and inspect the plant for signs of insects or disease.
Neem Oil is a good treatment.
Here are some links for you.
https://www.gardeningknowhow.com/ornamental/shrubs/butterfly-bush/butterfly-bush-care.htm
https://www.gardeningknowhow.com/plant-problems/pests/pesticides/neem-oil-uses.htm